Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open questions: add 'allowEmpty' flag #5

Open
noamoss opened this issue Mar 11, 2019 · 0 comments
Open

open questions: add 'allowEmpty' flag #5

noamoss opened this issue Mar 11, 2019 · 0 comments
Assignees
Projects

Comments

@noamoss
Copy link
Contributor

noamoss commented Mar 11, 2019

some of the questions (not all of them) should enable the user to submit without typing in ('anonymous' for the name is the clearest examples, but we already have two other cases in which currently we have to ask a yes/no question just to confirm in advance the user has some info to type in:

  • האם את/ה יודעים את שם חברת האבטחה?
  • האם את/ה יודעים את שם המאבטח/ת?

we should minimize/subtract these steps, without giving up on the standard content validation assumption for most of the question

notice

this issue is relevant for the reportit-agent part as well.

alternative solution:

handle the split method when an empty string is submitted into a this.content.setTextArea():

image

@noamoss noamoss added this to To do in Report-it via automation Jun 17, 2019
@akariv akariv moved this from To do to Prioritized in Report-it Aug 4, 2019
@noamoss noamoss moved this from Prioritized to To do in Report-it Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Report-it
  
To do
Development

No branches or pull requests

2 participants