Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart contract verification: Add note that solcjs doesn't support metadata generation with the method shown #499

Closed
ed-marquez opened this issue Nov 13, 2023 · 0 comments
Closed

Smart contract verification: Add note that solcjs doesn't support metadata generation with the method shown #499

ed-marquez opened this issue Nov 13, 2023 · 0 comments
Assignees
@theekrystallee
Labels
enhancement New feature or request

Comments

@ed-marquez
Copy link

Problem

This other issue highlights that solcjs does not support the --metadata flag even though solc does.

This section of our documentation (image below) shows the way to generate metadata. However, developers trying to use these same commands in JavaScript projects will run into issues.
image

Afaik, this npm package (JS binding for solc) does not support that --metadata flag.

Solution

  • Let's add a note that informs users that using the solc in JS will not generate the metadata because the option is not supported.

cc: @kr

Alternatives

No response
@ed-marquez ed-marquez added the enhancement New feature or request label Nov 13, 2023
gitbook-com bot pushed a commit that referenced this issue Nov 13, 2023
@theekrystallee @gitbook-bot
GITBOOK-2434: #499 fix
cb3ef3e
@theekrystallee theekrystallee self-assigned this Nov 13, 2023
SimiHunjan added a commit that referenced this issue Nov 13, 2023
@SimiHunjan @theekrystallee
@dalvizu @bguiz
Staging up to date with master branch (#500)
4107b54 
* GITBOOK-2431: #491 fix

* Remove two Dentons proxies (#496)

* GITBOOK-2434: #499 fix

* doc: HW seq for HSCS smart contract (#493)

* docs: Hello World seq: 00 create fund account

Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com>

* docs: add HW seq for HSCS smart contract

Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com>

---------

Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com>

---------

Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com>
Co-authored-by: krystal <krystal@swirldslabs.com>
Co-authored-by: Dan Alvizu <alvizu@gmail.com>
Co-authored-by: Brendan Graetz <bguiz@users.noreply.github.com>
SimiHunjan added a commit that referenced this issue Nov 13, 2023
@SimiHunjan @theekrystallee
@dalvizu @bguiz
Update staging branch (#501)
4c36868 
* GITBOOK-2431: #491 fix

* Remove two Dentons proxies (#496)

* GITBOOK-2434: #499 fix

* doc: HW seq for HSCS smart contract (#493)

* docs: Hello World seq: 00 create fund account

Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com>

* docs: add HW seq for HSCS smart contract

Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com>

---------

Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com>

---------

Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com>
Co-authored-by: krystal <krystal@swirldslabs.com>
Co-authored-by: Dan Alvizu <alvizu@gmail.com>
Co-authored-by: Brendan Graetz <bguiz@users.noreply.github.com>
SimiHunjan added a commit that referenced this issue Nov 13, 2023
@SimiHunjan @theekrystallee
@dalvizu @bguiz
Update staging (#502)
192cfcf 
* GITBOOK-2431: #491 fix

* Remove two Dentons proxies (#496)

* GITBOOK-2434: #499 fix

* doc: HW seq for HSCS smart contract (#493)

* docs: Hello World seq: 00 create fund account

Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com>

* docs: add HW seq for HSCS smart contract

Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com>

---------

Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com>

---------

Signed-off-by: Brendan Graetz <bguiz@users.noreply.github.com>
Co-authored-by: krystal <krystal@swirldslabs.com>
Co-authored-by: Dan Alvizu <alvizu@gmail.com>
Co-authored-by: Brendan Graetz <bguiz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theekrystallee theekrystallee

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theekrystallee @ed-marquez