Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable NFT allowance @acceptance tag in tests to remove conflict with ContractCall tests #8270

Closed
Tracked by #7480
mgoelswirlds opened this issue May 10, 2024 · 1 comment · Fixed by #8339
Closed
Tracked by #7480
Assignees
Labels
enhancement Type: New feature rest-java Area: Java REST API test Test infrastructure, automated tests required, etc
Milestone

Comments

@mgoelswirlds
Copy link
Member

mgoelswirlds commented May 10, 2024

Problem

Since the NFT allowance APIs use the same token as the contract call API to test , there was an issue after deleting the token.

To reproduce:

  1. Add @Acceptance in the nftAllowance.feature and run the acceptance tests on integration using a custom image.

Solution

  • We need to check how the serial numbers for the token are being set. After deletion that map should still be available to any other tests that use the same token.

Another line item is to change documentation in the openapi spec.

Alternatives

No response

@mgoelswirlds mgoelswirlds added the enhancement Type: New feature label May 10, 2024
@steven-sheehy steven-sheehy added this to the 0.105.0 milestone May 10, 2024
@mgoelswirlds mgoelswirlds self-assigned this May 10, 2024
@steven-sheehy steven-sheehy modified the milestones: 0.105.0, 0.106.0 May 13, 2024
@mgoelswirlds
Copy link
Member Author

After several tries on using a separate new accounts, vs all the existing NFTs in the acceptance. There were issues with each of the approaches because of the way tests are using specific tokens.
The way to get around this issue was to create a new token which is an expensive operation.

@steven-sheehy steven-sheehy added test Test infrastructure, automated tests required, etc rest-java Area: Java REST API labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature rest-java Area: Java REST API test Test infrastructure, automated tests required, etc
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants