Fix DialedDirectly configuration for Consul dataplane. #15760
Merged
+161
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashi-derek
force-pushed
the
derekm/NET-1719/dialed-directly-chains
branch
8 times, most recently
from
c90fc75
to
7ca8d26
Compare
hashi-derek
force-pushed
the
derekm/NET-1719/dialed-directly-chains
branch
from
7ca8d26
to
b9b929d
Compare
freddygv
reviewed
Dec 12, 2022
hashi-derek
force-pushed
the
derekm/NET-1719/dialed-directly-chains
branch
from
506eb4d
to
ea07eeb
Compare
erichaberkorn
approved these changes
Dec 13, 2022
hashi-derek
added
the
backport-inactive/1.14
t-eckert
pushed a commit
that referenced
this pull request
Dec 15, 2022
Fix DialedDirectly configuration for Consul dataplane.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DialedDirectlyconfiguration on upstreams is ignored by Consul Dataplane, because it selects data through the streaming backend which does not support theMergeCentralConfigflag. This means that any service-defaults or proxy-defaults configurations on upstreams were ignored.This PR adds the
DialedDirectlyconfig into the compiled discovery chain targets, so that the "merged" version is available to the proxy config.This PR also fixes an existing issue where passthrough clusters were not properly cleaned up whenever the
DialedDirectlyfield is toggled on and off during runtime.