Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember try and monorepos doesn't always do what we expect #208

Closed
Dhaulagiri opened this issue Apr 11, 2022 · 2 comments · Fixed by #223
Closed

ember try and monorepos doesn't always do what we expect #208

Dhaulagiri opened this issue Apr 11, 2022 · 2 comments · Fixed by #223
Labels
bug Something isn't working internal

Comments

@Dhaulagiri
Copy link
Contributor

Dhaulagiri commented Apr 11, 2022

A side effect of observing this run of ember-flight-icons only failing for the ember try scenarios has revealed what I think is a subtle problem with how ember-try is working in our monorepo setup.

What is happening

ember-try is running yarn from within the given package which is not how the yarn workspace "works". The install should always happen at the root.

What should happen

ember-try runs yarn from the workspace root and then runs the actual scenarios from within the specific page.

@Dhaulagiri Dhaulagiri added the bug Something isn't working label Apr 11, 2022
@Dhaulagiri
Copy link
Contributor Author

We could explore ember-try's workspace feature but I'm not sure if that is the best approach or not

@Dhaulagiri
Copy link
Contributor Author

Dhaulagiri commented Apr 11, 2022

ember-cli/ember-try#597 helps explain why this is happening (in part)

@Dhaulagiri Dhaulagiri linked a pull request Jun 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant