Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: give up early on 505, 506, 510, and 511 #175

Open
favonia opened this issue Oct 28, 2022 · 0 comments
Open

Feature request: give up early on 505, 506, 510, and 511 #175

favonia opened this issue Oct 28, 2022 · 0 comments

Comments

@favonia
Copy link

favonia commented Oct 28, 2022

In addition to 501, these errors seem permanent as well:

http.StatusHTTPVersionNotSupported       // 505 HTTP Version Not Supported
http.StatusVariantAlsoNegotiates         // 506 Variant Also Negotiates
http.StatusNotExtended                   // 510 Not Extended
http.StatusNetworkAuthenticationRequired // 511 Network Authentication Required

Perhaps we should skip the retry logic when we see one of them?

PS: I'm not sure about http.StatusLoopDetected (508 Loop Detected). Maybe we should include that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant