Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading message “This PR introduced no changes to the JavaScript bundle” #55

Open
gthb opened this issue Apr 18, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@gthb
Copy link

gthb commented Apr 18, 2023

The message “This PR introduced no changes to the JavaScript bundle” is misleading. It implies that the resulting JavaScript bundles are exactly the same bytes (not just the same lengths!), so if the PR intended to make some end-user-visible change, it is failing to do so. This can cause people (in particular people not familiar with the nextjs-bundle-analysis action) to think their changes are having no effect on end-user code, and waste time troubleshooting that.

The intended meaning is of course something like “This PR did not change any JavaScript bundle sizes [beyond the configured threshold]”.

@BRKalow BRKalow added the enhancement New feature or request label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants