Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap go-bindata for built-in Go embed #11922

Open
shoenig opened this issue Jan 24, 2022 · 0 comments
Open

Swap go-bindata for built-in Go embed #11922

shoenig opened this issue Jan 24, 2022 · 0 comments
Labels
theme/cleanup theme/dependencies Pull requests that update a dependency file type/enhancement

Comments

@shoenig
Copy link
Member

shoenig commented Jan 24, 2022 •
edited

Fun fact: the current owner of go-bindata become so by hijacking the github repo.

Go now provides a built-in way for embedding statics, via embed

We can replace use of the 3rd party go-bindata tool and go-bindata-assetfs library with go:embed.

Vault has already made the switch: hashicorp/vault#11208

Consul intends to do has done so: hashicorp/consul#10996
@shoenig shoenig added type/enhancement theme/cleanup theme/dependencies Pull requests that update a dependency file labels Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme/cleanup theme/dependencies Pull requests that update a dependency file type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shoenig