Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyring: keys stuck in rekeying after rotate -full #19368

Open
tgross opened this issue Dec 7, 2023 · 2 comments
Open

keyring: keys stuck in rekeying after rotate -full #19368

tgross opened this issue Dec 7, 2023 · 2 comments

Comments

@tgross
Copy link
Member

tgross commented Dec 7, 2023

In #19340 @sbihel reported a behavior where keys would get stuck in rekeying after running nomad operator root keyring rotate -full. I was able to confirm this and build a quick unit test to cover it, but I don't yet have a fix for the underlying problem.

#19340 covered another critical bug and was automatically closed once the fix was merged. This issue is a follow-up.

@tgross
Copy link
Member Author

tgross commented Dec 7, 2023

Note that following Nomad 1.7.0, we don't easily know when it's safe to delete keys anymore. We don't have the WI in the state store so there's no easy way to map from a set of allocations with WI's signed by a given key to that key. We do have the SignedIdentities map in the allocation, but reading this would involve unpacking all the JWTs in that map for each allocation we want to check.

@tgross
Copy link
Member Author

tgross commented Jan 9, 2024

Ref #19669

@tgross tgross modified the milestones: 1.7.x, 1.8.x Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant