Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csi] Support for Plugins written in not-Go #8492

Closed
endocrimes opened this issue Jul 22, 2020 · 4 comments
Closed

[csi] Support for Plugins written in not-Go #8492

endocrimes opened this issue Jul 22, 2020 · 4 comments
Labels
theme/dependencies Pull requests that update a dependency file theme/storage
Milestone

Comments

@endocrimes
Copy link
Contributor

Filling this so it gets tracked, although an upstream release (of grpc-go) is not ready yet that I know of.

Summary

Due to a bug in grpc-go, go grpc clients that communicate over a unix domain socket currently can not communicate with strict server implementations due to an empty authority header.

This should only affect nomad through CSI plugin support, as iirc no other grpc communication goes through a UDS.

See the following issue (and linked GRPC issues): kubernetes/kubernetes#93320

@tgross
Copy link
Member

tgross commented Jul 22, 2020

Thanks for the heads up, @endocrimes! I'll be keeping an eye on https://github.com/grpc/grpc-go/releases

@tgross tgross added theme/storage theme/dependencies Pull requests that update a dependency file labels Jul 22, 2020
@tgross
Copy link
Member

tgross commented Aug 11, 2020

The grpc fix was released as https://github.com/grpc/grpc-go/releases/tag/v1.31.0

@tgross tgross added this to Needs Roadmapping in Nomad - Community Issues Triage Feb 12, 2021
@tgross tgross removed this from Needs Roadmapping in Nomad - Community Issues Triage Mar 4, 2021
@tgross
Copy link
Member

tgross commented Nov 18, 2021

Closed by the gRPC library update in #11481

@tgross tgross closed this as completed Nov 18, 2021
@tgross tgross added this to the 1.2.1 milestone Nov 18, 2021
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/dependencies Pull requests that update a dependency file theme/storage
Projects
None yet
Development

No branches or pull requests

2 participants