Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "image_version" explicitly set to "latest" for all source images #254

Open
nkadel opened this issue Dec 19, 2022 · 0 comments
Open

Add "image_version" explicitly set to "latest" for all source images #254

nkadel opened this issue Dec 19, 2022 · 0 comments

Comments

@nkadel
Copy link

nkadel commented Dec 19, 2022

Please search the existing issues for relevant feature requests, and use the
reaction feature
(https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/)
to add upvotes to pre-existing requests.

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request.
If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

The VM image settings include "imae_publisher", "image_sku", and "image_offer". This should be explicitly set to also use "image_version" of "latest". The option is inconsistently listed, and relying on the implicit "latest" option is confusing.

Use Case(s)

The Azure tools use the "latest" image by default, but it's implicit, not explicit. Setting it consistently and explicitly helps personnel ifnd the right place to more specifically designate that value.

Potential configuration

See: azure/arm/builder_acc_test.go and examples/rhel.json. The

--- a/builder/azure/arm/builder_acc_test.go
+++ b/builder/azure/arm/builder_acc_test.go
@@ -380,6 +380,7 @@ func testBuilderUserDataLinux(userdata string) string {
          "image_publisher": "Canonical",
          "image_offer": "UbuntuServer",
          "image_sku": "16.04-LTS",
+         "image_version": "latest",
          "user_data_file": "%s",
 
          "location": "South Central US",

Potential References

@nkadel nkadel changed the title Add "image_version" explicitly set to "latest" for all Azure VM images Add "image_version" explicitly set to "latest" for all source images Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant