Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for NonPersistedTPM Confidential VM Encryption Option #395

Open
JenGoldstrich opened this issue Mar 25, 2024 · 3 comments
Open
Labels
builder/arm issues Related to the ARM builder enhancement sync to jira

Comments

@JenGoldstrich
Copy link
Contributor

JenGoldstrich commented Mar 25, 2024

Follow up to #373

Confidential VMs can't be published to multiple regions currently due to the absence of NonPersistedTPM option in current galleryimageversion API

The following needs to be done to solve this issue

  1. Submit a PR to Pandora Azure SDK generation tool to add 2024-03-01 API version which contains the above option.

  2. Update code base to use new version of the SDK, this will require updating a few different clients.

  3. Add logic to parse NonPersistantTPM option, and set it in Confidential VM Encryption type setting, ensuring that it allows multi-region deploys

@JenGoldstrich JenGoldstrich changed the title Add Support for NonPersistantTMP Option Add Support for NonPersistantTPM Confidential VM Encryption Option Mar 25, 2024
@JenGoldstrich JenGoldstrich self-assigned this Mar 26, 2024
Copy link

This issue has been synced to JIRA for planning.
JIRA ID: [HPR-1692](https://hashicorp.atlassian.net/browse/HPR-1692)

@JenGoldstrich
Copy link
Contributor Author

that was the wrong API version actually oops, hashicorp/pandora#4032 new PR for Pandora here

@JenGoldstrich JenGoldstrich changed the title Add Support for NonPersistantTPM Confidential VM Encryption Option Add Support for NonPersistedTPM Confidential VM Encryption Option Apr 2, 2024
@JenGoldstrich
Copy link
Contributor Author

So this feature is actually not in a stable API yet in the virtual machines API, so we have decided to hold off until it is published in a stable API and then we will add support for this feature.

@JenGoldstrich JenGoldstrich removed their assignment Apr 16, 2024
@JenGoldstrich JenGoldstrich added the builder/arm issues Related to the ARM builder label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder/arm issues Related to the ARM builder enhancement sync to jira
Projects
None yet
Development

No branches or pull requests

1 participant