feat: add vapp properties #299
Conversation
|
|
|
Please merge, feature would be useful @JenGoldstrich Can you review? |
|
@MrKeiKun Couls to please provide A summary and test results in the pull request description? |
tenthirtyam
added
enhancement
stage/waiting-reply
builder/vsphere-iso
|
CI is failing. |
There was a problem hiding this comment.
Hi @MrKeiKun,
The initial draft looks OK to me, I left a fix suggestion for the generation problem, I believe that if you change the type to be a public structure, it should mend the generated code.
That being said, I'm not sure we need to introduce an extra structure to the package, it seems the only attribute could be directly part of the general config, especially since we don't define any function on the structure itself.
On another note, I am very much unfamiliar with VSphere so please bear with me here, but are there other kind of configs we want to support regarding the VAppConfig? I'm also a bit cautious regarding the properties type, since it's a map of string->string, this implies that all attributes' value must be a string, and from the screenshot I saw, there seems to be multiple possibilities, is that right? I see on the issue someone trying to input some XML, is there a standard format to specify that, with type information? If so we should probably aim to support this also (though this can be for later I presume).
tenthirtyam
force-pushed
the
vapp
branch
2 times, most recently
from
358cb17
to
67d7936
Compare
|
✅ CI is now Successful. |
There was a problem hiding this comment.
The changes look good to me as well. But as Lucas mentioned there is room for improvement when it comes to the vAppConfig type. It also appears that since this is in both iso and clone builders things can be brought into common. But we can leave that for a separate PR.
@tenthirtyam thanks for pushing forward and testing. I will approve the PR as is and wait to hear back on the docs before merging.
|
Marking this as draft for further review and outcome testing before merging. |
tenthirtyam
added
the
stage/needs-verification
|
Any Updates to this? |
|
Agree, I've still got the issue in #305. Would be good to get this merged even in a "beta state". Currently with OVF templates the only work around is to use ssh/remote-exec provisioners which are marked by hashicorp "last resort." |
|
@adeturner Can you please provide some examples for your ssh/remote exec to this issue? |
|
@harlequin no worries, see remote_exec_workaround and the_vapp_ideal |
|
Thus far, I've not been able to perform a build that will apply these properties to an image with the @MrKeiKun 👋 - could you please provide a summary, minimal configuration example, test results in the pull request description? Without this information I am reticent to move this one forward until the this can be successfully tested. |
No description provided.