missing dependency in @cdktf/hcl2json: performance package isn't installed but is required

[sagilaufer1992]

Expected Behavior

using version v0.17.3 should work smoothly without any other dependencies installed

Actual Behavior

got the following error:

ERROR in ../../node_modules/.pnpm/@cdktf+hcl2json@0.17.3/node_modules/@cdktf/hcl2json/wasm/bridge_wasm_exec.js 14:27-49
Module not found: Error: Can't resolve 'performance' in '/tmp/seed/source/node_modules/.pnpm/@cdktf+hcl2json@0.17.3/node_modules/@cdktf/hcl2json/wasm'
resolve 'performance' in '/tmp/seed/source/node_modules/.pnpm/@cdktf+hcl2json@0.17.3/node_modules/@cdktf/hcl2json/wasm'

Steps to Reproduce

• add version v0.17.3
• compile with webpack
• fail

Versions

"@cdktf/hcl2json": "0.17.3"

Providers

No response

Gist

No response

Possible Solutions

add performance to the package's package.json file as a dependency

Workarounds

No response

Anything Else?

No response

References

No response

Help Wanted

• I'm interested in contributing a fix myself

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[ansgarm]

Hi @sagilaufer1992 👋

The performance package is built into Node.js and requires Node.js 16 or later. It seems that Webpack might need an update (similar to this one) to add performance as it's currently not in the list for the node target – but that's just a guess.

Depending on your Webpack config and version you might also be running into this: webpack/webpack#11282

[sagilaufer1992]

we use an up-to-date version of webpack, and Node v16.x.x. so from your comment the issue is with my webpack configuration, and probably will require mending in it or in webpack itself (inserting it to the list above)?

[github-actions]

Hi there! 👋 We haven't heard from you in 15 days and would like to know if the problem has been resolved or if you still need help. If we don't hear from you before then, I'll auto-close this issue in 30 days.

[github-actions]

I'm closing this issue because we haven't heard back in 45 days. ⌛️ If you still need help, feel free to comment or reopen the issue!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.