Low performance in deduplicate strings function

[AntoniJakubiak]

terraform-plugin-sdk/terraform/util.go

Line 16 in b7c8ee7

sort.Strings(s)

A typical implementation is:

input []string

m := make(map[string]bool, len(input))
for _, v := range input {
  m[v] = true
}
output := make(input, len(m))
i := 0
for v := range m {
 output[i] = v
 i++
}

[austinvalle]

Hi there @AntoniJakubiak 👋🏻 ,

Can you provide some more detail about how this performance is affecting your usage of the github.com/hashicorp/terraform-plugin-sdk/terraform Go module?

From what I see, the function referenced is only called by the (terraform.State).Remove function

[AntoniJakubiak]

Hi,

Sorry for bothering you. I thought, that I'm in the middle of different project.

;)

[austinvalle]

No problem @AntoniJakubiak!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.