Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging using terraform-plugin-log. #837

Merged
merged 2 commits into from Dec 23, 2021
Merged

Add logging using terraform-plugin-log. #837

merged 2 commits into from Dec 23, 2021

Conversation

paddycarver
Copy link
Contributor

Start using terraform-plugin-log to log SDKv2 level logs, using an
SDKv2-specific subsystem. The environment variable TF_LOG_SDK_V2
controls the subsystem's log output.

Fixes #804.

@paddycarver
Add logging using terraform-plugin-log.
e2ac8e5 
Start using terraform-plugin-log to log SDKv2 level logs, using an
SDKv2-specific subsystem. The environment variable `TF_LOG_SDK_V2`
controls the subsystem's log output.
@paddycarver paddycarver requested a review from a team December 23, 2021 17:31
bflad
bflad approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little hesitant on the subsystem name and environment variable including versioning information (maybe that versioning could be added as a separate key-value to the logging context), but otherwise looks good to me. 🚀

helper/schema/grpc_provider.go Outdated Show resolved Hide resolved
helper/schema/grpc_provider.go Outdated Show resolved Hide resolved
bflad
bflad approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love using helper_schema (and helper_resource for the testing framework in the future) 👍 👍 👍

@paddycarver paddycarver merged commit 89ca073 into main Dec 23, 2021
@paddycarver paddycarver deleted the paddy_add_logging branch December 23, 2021 18:59
@bflad bflad mentioned this pull request Dec 23, 2021
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration with terraform-plugin-log
2 participants
@paddycarver @bflad