Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customdiff: Use warning log instead of returning errors in ComputedIf, ForceNewIf, and ForceNewIfChange #909

Merged
merged 2 commits into from Mar 17, 2022
Merged

customdiff: Use warning log instead of returning errors in ComputedIf, ForceNewIf, and ForceNewIfChange #909

merged 2 commits into from Mar 17, 2022

Conversation

bflad
Copy link
Member

@bflad bflad commented Mar 17, 2022

Closes #908

@bflad
customdiff: Use warning log instead of returning errors in `ComputedI…
ef69600 
…f`, `ForceNewIf`, and `ForceNewIfChange`

Reference: #908
@bflad bflad added the bug Something isn't working label Mar 17, 2022
@bflad bflad added this to the v2.11.1 milestone Mar 17, 2022
@bflad bflad requested a review from a team as a code owner March 17, 2022 16:20
detro
detro approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@detro detro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@detro
Copy link
Contributor

detro commented Mar 17, 2022

This was quite a tricky one.

@bflad bflad merged commit ef9d2e2 into main Mar 17, 2022
@bflad bflad deleted the bflad-customdiff-warn-not-error branch March 17, 2022 17:44
@bflad bflad modified the milestones: v2.11.1, v2.12.0 Mar 17, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@detro detro detro approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.

CustomizeDiff "invalid key" error after v2.11.0 upgrade
2 participants
@bflad @detro