Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b-aws_lightsail_distribution:attach certificate #36888

Merged
merged 5 commits into from Apr 17, 2024

Conversation

nikhil-goenka
Copy link
Contributor

Description

Relations

Closes #36885

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/lightsail Issues and PRs that pertain to the lightsail service. size/XS Managed by automation to categorize the size of a PR. labels Apr 12, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 12, 2024
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 15, 2024
```console
% make testacc PKG=lightsail TESTS=TestAccLightsailDistribution_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run='TestAccLightsailDistribution_'  -timeout 360m

--- PASS: TestAccLightsailDistribution_serial (4836.37s)
    --- PASS: TestAccLightsailDistribution_serial/distribution (4836.37s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/ip_address_type (764.42s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/tags (358.52s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/basic (331.67s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/disappears (397.95s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/is_enabled (997.34s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/cache_behavior (644.61s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/cache_behavior_settings (640.05s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/default_cache_behavior (701.81s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  4841.919s
```
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=lightsail TESTS=TestAccLightsailDistribution_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run='TestAccLightsailDistribution_'  -timeout 360m

--- PASS: TestAccLightsailDistribution_serial (4836.37s)
  --- PASS: TestAccLightsailDistribution_serial/distribution (4836.37s)
      --- PASS: TestAccLightsailDistribution_serial/distribution/ip_address_type (764.42s)
      --- PASS: TestAccLightsailDistribution_serial/distribution/tags (358.52s)
      --- PASS: TestAccLightsailDistribution_serial/distribution/basic (331.67s)
      --- PASS: TestAccLightsailDistribution_serial/distribution/disappears (397.95s)
      --- PASS: TestAccLightsailDistribution_serial/distribution/is_enabled (997.34s)
      --- PASS: TestAccLightsailDistribution_serial/distribution/cache_behavior (644.61s)
      --- PASS: TestAccLightsailDistribution_serial/distribution/cache_behavior_settings (640.05s)
      --- PASS: TestAccLightsailDistribution_serial/distribution/default_cache_behavior (701.81s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  4841.919s

@jar-b
Copy link
Member

jar-b commented Apr 17, 2024

Thanks for your contribution, @nikhil-goenka! 🚀

@jar-b jar-b merged commit 9198fc2 into hashicorp:main Apr 17, 2024
33 checks passed
@github-actions github-actions bot added this to the v5.46.0 milestone Apr 17, 2024
Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/lightsail Issues and PRs that pertain to the lightsail service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Attaching Lightsail Certificate to Lightsail Distribution does not work
3 participants