From 55e8dc199e6c8c42a764ff74f9c06c833a526138 Mon Sep 17 00:00:00 2001 From: Matthew Frahry Date: Wed, 13 May 2020 14:06:19 -0700 Subject: [PATCH] `data.azurerm_security_group` - fixing crash where id is nil #6910 --- .../services/network/network_security_group_data_source.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/azurerm/internal/services/network/network_security_group_data_source.go b/azurerm/internal/services/network/network_security_group_data_source.go index b2d9f09c9d31..f4ab5881e981 100644 --- a/azurerm/internal/services/network/network_security_group_data_source.go +++ b/azurerm/internal/services/network/network_security_group_data_source.go @@ -148,9 +148,12 @@ func dataSourceArmNetworkSecurityGroupRead(d *schema.ResourceData, meta interfac if utils.ResponseWasNotFound(resp.Response) { return fmt.Errorf("Error: Network Security Group %q (Resource Group %q) was not found", name, resourceGroup) } - return fmt.Errorf("Error making Read request on Network Security Group %q (Resource Group %q): %+v", name, resourceGroup, err) + return fmt.Errorf("making Read request on Network Security Group %q (Resource Group %q): %+v", name, resourceGroup, err) } + if resp.ID == nil || *resp.ID == "" { + return fmt.Errorf("reading request on Network Security Group %q (Resource Group %q): %+v", name, resourceGroup, err) + } d.SetId(*resp.ID) d.Set("name", resp.Name)