Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request: Support for All Namespaces in "azurerm_data_protection_backup_instance_kubernetes_cluster"Support for [thing] #25730

Open
1 task done
shwetha1987u opened this issue Apr 24, 2024 · 0 comments

Comments

@shwetha1987u
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

I've encountered limitations with the azurerm_data_protection_backup_instance_kubernetes_cluster resource that impact usability for scenarios requiring namespace-wide Kubernetes backups:

  1. Missing "All Namespaces" Option: The backup_datasource_parameters argument block lacks an all_namespaces parameter that would automatically include all namespaces for backup, requiring users to manually specify each namespace.

  2. "included_namespaces" Parameter Limitation: The included_namespaces parameter within the backup_datasource_parameters does not accept universal selectors like * or all, which would typically be used to denote the inclusion of all namespaces.

I believe introducing an all_namespaces parameter or allowing included_namespaces to accept values like * or all would be a much needed functionality.

New or Affected Resource(s)/Data Source(s)

azurerm_data_protection_backup_instance_kubernetes_cluster

Potential Terraform Configuration

resource "azurerm_data_protection_backup_instance_kubernetes_cluster" "example" {
  name                         = "example"
  location                     = azurerm_resource_group.example.location
  vault_id                     = azurerm_data_protection_backup_vault.example.id
  kubernetes_cluster_id        = azurerm_kubernetes_cluster.example.id
  snapshot_resource_group_name = azurerm_resource_group.snap.name
  backup_policy_id             = azurerm_data_protection_backup_policy_kubernetes_cluster.example.id

  backup_datasource_parameters {
    excluded_namespaces              = ["test-excluded-namespaces"]
    excluded_resource_types          = ["exvolumesnapshotcontents.snapshot.storage.k8s.io"]
    cluster_scoped_resources_enabled = true
    included_namespaces              = ["all"]
    all_namespaces                   = true
    included_resource_types          = ["involumesnapshotcontents.snapshot.storage.k8s.io"]
    label_selectors                  = ["kubernetes.io/metadata.name:test"]
    volume_snapshot_enabled          = true
  }
}

References

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants