Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to turn off subscription key in API Management API #4884

Closed
jackbatzner opened this issue Nov 14, 2019 · 5 comments
Closed

Add ability to turn off subscription key in API Management API #4884

jackbatzner opened this issue Nov 14, 2019 · 5 comments

Comments

@jackbatzner
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The azurerm_api_management_api resource is missing the ability to set the ability to require a subscription key to false.

(https://github.com/Azure/azure-sdk-for-go/blob/master/services/apimanagement/mgmt/2018-01-01/apimanagement/models.go#L949).

New or Affected Resource(s)

  • azurerm_api_management_api

Potential Terraform Configuration

resource "azurerm_api_management_api" "test" {
  name                = "acctestapi-%d"
  resource_group_name = "${azurerm_resource_group.test.name}"
  api_management_name = "${azurerm_api_management.test.name}"
  display_name        = "Butter Parser"
  path                = "butter-parser"
  protocols           = ["https", "http"]
  revision            = "3"
  description         = "What is my purpose? You parse butter."
  service_url         = "https://example.com/foo/bar"
  
  authentication_settings {
	 subscription_key_required = false
  }
}

References

jackbatzner pushed a commit to jackbatzner/terraform-provider-azurerm that referenced this issue Nov 14, 2019
jackbatzner pushed a commit to jackbatzner/terraform-provider-azurerm that referenced this issue Nov 14, 2019
@BernhardRode
Copy link

Any news, when this feature will be release? =)

@jackbatzner
Copy link
Contributor Author

jackbatzner commented Mar 13, 2020

@BernhardRode, as mentioned in PR 4885, this is blocked by Azure/azure-rest-api-specs#6372. When that gets completed I can pick this up again 😄

@rvilike
Copy link

rvilike commented Apr 18, 2020

@Brunhil Azure/azure-rest-api-specs#6372 is done now, as I can see 😊

jackbatzner pushed a commit to jackbatzner/terraform-provider-azurerm that referenced this issue Apr 24, 2020
jackbatzner pushed a commit to jackbatzner/terraform-provider-azurerm that referenced this issue Jun 16, 2020
@jackbatzner
Copy link
Contributor Author

jackbatzner commented Jun 25, 2020

This was recently released/closed by #4885 . Also released in version 2.16.0

@ghost
Copy link

ghost commented Jul 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants