Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management_diagnostic fails after 2.7.0 #6619

Closed
rvilike opened this issue Apr 24, 2020 · 4 comments · Fixed by #6682
Closed

azurerm_api_management_diagnostic fails after 2.7.0 #6619

rvilike opened this issue Apr 24, 2020 · 4 comments · Fixed by #6682

Comments

@rvilike
Copy link

rvilike commented Apr 24, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Terraform v0.12.24
azurerm v2.7.0

Affected Resource(s)

  • azurerm_api_management_diagnostic

Terraform Configuration Files

resource "azurerm_api_management" "apim" {
  name = var.name
  location = var.location
  resource_group_name = var.resource_group_name
  publisher_name = var.publisher_name
  publisher_email = var.publisher_email
  sku_name = var.sku_name

  virtual_network_type = var.virtual_network_type
  virtual_network_configuration {
    subnet_id = var.subnet_id
  }

  tags = var.tags
}

resource "azurerm_api_management_logger" "apim-logger" {
  name = var.name
  api_management_name = azurerm_api_management.apim.name
  resource_group_name = var.resource_group_name

  application_insights {
    instrumentation_key = var.appinsights_instrumentation_key
  }
}

resource "azurerm_api_management_diagnostic" "apim-diagnostic" {
  identifier = "applicationinsights"
  api_management_name = azurerm_api_management.apim.name
  resource_group_name = var.resource_group_name
}

Debug Output

Panic Output

Expected Behavior

APIM diagnostic gets created

Actual Behavior

Creating APIM diagnostic fails with:
Error: creating or updating Diagnostic "applicationinsights" (Resource Group "..." / API Management Service "..."): apimanagement.DiagnosticClient#CreateOrUpdate: Invalid input: autorest/validation: validation failed: parameter=parameters.DiagnosticContractProperties.LoggerID constraint=Null value=(*string)(nil) details: value can not be null; required parameter

Steps to Reproduce

  1. terraform apply

Important Factoids

References

@yupwei68
Copy link
Contributor

hi @rvilike ,thanks for opening this issue. This is a regression bug. And we will fix it by adding logger_id in azurerm_api_management_diagnostic later.

@evertonmc
Copy link
Contributor

This is a regression bug.

yes, and also the reason for #6104

@katbyte katbyte added this to the v2.10.0 milestone May 14, 2020
katbyte pushed a commit that referenced this issue May 14, 2020
…management_logger_id` (#6682)

fix #6619

This will be a breaking change for it adds a required field "logger_id"

=== RUN TestAccAzureRMApiManagementDiagnostic_basic
=== PAUSE TestAccAzureRMApiManagementDiagnostic_basic
=== CONT TestAccAzureRMApiManagementDiagnostic_basic
--- PASS: TestAccAzureRMApiManagementDiagnostic_basic (2498.17s)
=== RUN TestAccAzureRMApiManagementDiagnostic_update
=== PAUSE TestAccAzureRMApiManagementDiagnostic_update
=== CONT TestAccAzureRMApiManagementDiagnostic_update
--- PASS: TestAccAzureRMApiManagementDiagnostic_update (2566.13s)
=== RUN TestAccAzureRMApiManagementDiagnostic_requiresImport
=== PAUSE TestAccAzureRMApiManagementDiagnostic_requiresImport
=== CONT TestAccAzureRMApiManagementDiagnostic_requiresImport
--- PASS: TestAccAzureRMApiManagementDiagnostic_requiresImport (2330.79s)
PASS

(also fixes #6104)
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants