Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Service - Plan shows site_credentials in cleartext #7183

Closed
sebader opened this issue Jun 3, 2020 · 3 comments
Closed

App Service - Plan shows site_credentials in cleartext #7183

sebader opened this issue Jun 3, 2020 · 3 comments
Labels
service/app-service upstream/terraform This issue is blocked on an upstream issue within Terraform (Terraform Core/CLI, The Plugin SDK etc)

Comments

@sebader
Copy link
Contributor

sebader commented Jun 3, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Terraform v0.12.26
azurerm v2.12.0

Affected Resource(s)

  • azurerm_app_service

Expected Behavior

No credentials should ever be printed in the logs in cleartext

Actual Behavior

When terraform plan detects a change to an existing app service, it prints the site_credentials (password and username) in cleartext:

image

Steps to Reproduce

Make any changes that cause an existing app service to be updated by terraform and run plan.

  1. terraform plan
@tombuildsstuff tombuildsstuff added the upstream/terraform This issue is blocked on an upstream issue within Terraform (Terraform Core/CLI, The Plugin SDK etc) label Jun 3, 2020
@tombuildsstuff
Copy link
Member

hi @sebader

Thanks for opening this issue.

Taking a look into this, the root cause of this appears to be this bug in the Terraform Plugin SDK - since this would be fixed there (rather than here) I'm going to close this issue for the moment - would you mind subscribing to that issue for updates? When the fix becomes available we'll pull it in and that should fix this.

Thanks!

@hbuckle
Copy link
Contributor

hbuckle commented Jun 16, 2020

@tombuildsstuff - there seems to be very little interest in fixing the issue on the SDK side (unless you know any different?). The response from @paultyng was

The definitive response is treat it all as sensitive.

Given that, can we look to mark the whole block as sensitive on the AzureRM provider side?

@ghost
Copy link

ghost commented Jul 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/app-service upstream/terraform This issue is blocked on an upstream issue within Terraform (Terraform Core/CLI, The Plugin SDK etc)
Projects
None yet
Development

No branches or pull requests

4 participants