From 3f01615dfe47c1023406f2427b5117ed4df1eb03 Mon Sep 17 00:00:00 2001 From: Matthew Frahry Date: Wed, 13 May 2020 13:01:52 -0700 Subject: [PATCH 1/2] Fix crash in monitor diagnositc setting --- .../services/monitor/monitor_diagnostic_setting_resource.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/azurerm/internal/services/monitor/monitor_diagnostic_setting_resource.go b/azurerm/internal/services/monitor/monitor_diagnostic_setting_resource.go index bea152d2eed5..f0afd751789d 100644 --- a/azurerm/internal/services/monitor/monitor_diagnostic_setting_resource.go +++ b/azurerm/internal/services/monitor/monitor_diagnostic_setting_resource.go @@ -463,7 +463,7 @@ func expandMonitorDiagnosticsSettingsMetrics(input []interface{}) []insights.Met policiesRaw := v["retention_policy"].([]interface{}) var retentionPolicy *insights.RetentionPolicy - if policiesRaw != nil { + if policiesRaw != nil && len(policiesRaw) > 0 && policiesRaw[0] != nil { policyRaw := policiesRaw[0].(map[string]interface{}) retentionDays := policyRaw["days"].(int) retentionEnabled := policyRaw["enabled"].(bool) From b72b49e600d29e51be077e1119d39e7ab51daaa7 Mon Sep 17 00:00:00 2001 From: Matthew Frahry Date: Wed, 13 May 2020 14:05:53 -0700 Subject: [PATCH 2/2] lint --- .../services/monitor/monitor_diagnostic_setting_resource.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/azurerm/internal/services/monitor/monitor_diagnostic_setting_resource.go b/azurerm/internal/services/monitor/monitor_diagnostic_setting_resource.go index f0afd751789d..b392002e0154 100644 --- a/azurerm/internal/services/monitor/monitor_diagnostic_setting_resource.go +++ b/azurerm/internal/services/monitor/monitor_diagnostic_setting_resource.go @@ -463,7 +463,7 @@ func expandMonitorDiagnosticsSettingsMetrics(input []interface{}) []insights.Met policiesRaw := v["retention_policy"].([]interface{}) var retentionPolicy *insights.RetentionPolicy - if policiesRaw != nil && len(policiesRaw) > 0 && policiesRaw[0] != nil { + if len(policiesRaw) > 0 && policiesRaw[0] != nil { policyRaw := policiesRaw[0].(map[string]interface{}) retentionDays := policyRaw["days"].(int) retentionEnabled := policyRaw["enabled"].(bool)