From f6e6f31f75e0ebb56f0e2cb08b6d23a7c0bce8b0 Mon Sep 17 00:00:00 2001 From: Tracy Holmes Date: Tue, 26 May 2020 14:35:42 -0500 Subject: [PATCH 1/3] Adds `EnableMessagingLogs` to validation --- .../internal/services/signalr/resource_arm_signalr_service.go | 1 + 1 file changed, 1 insertion(+) diff --git a/azurerm/internal/services/signalr/resource_arm_signalr_service.go b/azurerm/internal/services/signalr/resource_arm_signalr_service.go index ce3e45dd9ad3..1b1e64ab5a55 100644 --- a/azurerm/internal/services/signalr/resource_arm_signalr_service.go +++ b/azurerm/internal/services/signalr/resource_arm_signalr_service.go @@ -86,6 +86,7 @@ func resourceArmSignalRService() *schema.Resource { Required: true, ValidateFunc: validation.StringInSlice([]string{ string(signalr.EnableConnectivityLogs), + string(signalr.EnableMessagingLogs), string(signalr.ServiceMode), }, false), }, From ac83a972d137edf31b2d9c55f84dbab40c79618d Mon Sep 17 00:00:00 2001 From: Tracy Holmes Date: Tue, 26 May 2020 14:43:08 -0500 Subject: [PATCH 2/3] Adds updated features value to docs --- website/docs/r/signalr_service.html.markdown | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/docs/r/signalr_service.html.markdown b/website/docs/r/signalr_service.html.markdown index 0e73becdd97f..dbb9c42435d0 100644 --- a/website/docs/r/signalr_service.html.markdown +++ b/website/docs/r/signalr_service.html.markdown @@ -67,7 +67,7 @@ A `cors` block supports the following: A `features` block supports the following: -* `flag` - (Required) The kind of Feature. Possible values are `EnableConnectivityLogs` and `ServiceMode`. +* `flag` - (Required) The kind of Feature. Possible values are `EnableConnectivityLogs`, `EnableMessagingLogs`, and `ServiceMode`. * `value` - (Required) A value of a feature flag. Possible values are `Classic`, `Default` and `Serverless`. From f146e7748d0a393f9b943b29d0f99d3bedef42f3 Mon Sep 17 00:00:00 2001 From: Tracy Holmes Date: Thu, 28 May 2020 14:56:53 -0500 Subject: [PATCH 3/3] Updates w/actual string & comment --- .../internal/services/signalr/resource_arm_signalr_service.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/azurerm/internal/services/signalr/resource_arm_signalr_service.go b/azurerm/internal/services/signalr/resource_arm_signalr_service.go index 1b1e64ab5a55..baf384de6ac0 100644 --- a/azurerm/internal/services/signalr/resource_arm_signalr_service.go +++ b/azurerm/internal/services/signalr/resource_arm_signalr_service.go @@ -85,8 +85,10 @@ func resourceArmSignalRService() *schema.Resource { Type: schema.TypeString, Required: true, ValidateFunc: validation.StringInSlice([]string{ + // Looks like the default has changed, ours will need to be updated in AzureRM 3.0. + // issue has been created https://github.com/Azure/azure-sdk-for-go/issues/9619 + "EnableMessagingLogs", string(signalr.EnableConnectivityLogs), - string(signalr.EnableMessagingLogs), string(signalr.ServiceMode), }, false), },