Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rocky-linux-cloud to the builtin project to search for images if image name contains rocky-linux #11184

Comments

@kwibus
Copy link
Contributor

kwibus commented Feb 28, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Add rocky-linux-cloud to the builtin project to search for images if image name contains rocky-linux

It`s only a small change, I will provide a pull request.

New or Affected Resource(s)

  • google_compute_instance
  • google_compute_instance_template

Potential Terraform Configuration

people can write:

 boot_disk {
    initialize_params {
      image = "rocky-linux-8"
    }
  }

instead of

 boot_disk {
    initialize_params {
      image = "rocky-linux-cloud\rocky-linux-8"
    }
  }

References

#10401 Also mentions this but is about coreos
#9522 Closed issue where someone though rocky-linux-8 did not work because you had to specify source project

kwibus pushed a commit to atcomputing/terraform-provider-google that referenced this issue Feb 28, 2022
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Mar 3, 2022
…image name contains rocky-linux Closes hashicorp#11184 (hashicorp#5773)

Co-authored-by: Rens Sikma <rens@atcomputing.nl>
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Mar 3, 2022
…image name contains rocky-linux Closes #11184 (#5773) (#11209)

Co-authored-by: Rens Sikma <rens@atcomputing.nl>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Rens Sikma <rens@atcomputing.nl>
@github-actions
Copy link

github-actions bot commented Apr 3, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.