Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name validation for load balancer resources. #12507

Open
natedogith1 opened this issue Sep 8, 2022 · 1 comment
Open

Add name validation for load balancer resources. #12507

natedogith1 opened this issue Sep 8, 2022 · 1 comment

Comments

@natedogith1
Copy link

natedogith1 commented Sep 8, 2022

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Add resource name validation for resources used for load balancing. It looks like these already document the requirements for the name, but don't actually validate that those requirements are met.

New or Affected Resource(s)

  • google_compute_health_check
  • google_compute_http_health_check
  • google_compute_https_health_check
  • google_compute_region_health_check
  • google_compute_backend_service
  • google_compute_region_backend_service
  • google_compute_forwarding_rule
  • google_compute_global_forwarding_rule

b/337873734
b/337873535

@rileykarson rileykarson added this to the Backlog milestone Sep 12, 2022
@melinath melinath added forward/exempt Never forward this issue and removed forward/review In review; remove label to forward labels Nov 17, 2023
@rileykarson rileykarson removed the forward/exempt Never forward this issue label Apr 29, 2024
@rileykarson rileykarson modified the milestones: Backlog, Goals Apr 29, 2024
@rileykarson
Copy link
Collaborator

Note: GCE resources have well known, very static rules, so this seems reasonable.

For other resources we are sometimes less confident so this may not generalize past GCE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants