Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support annotations in google_cloud_run_v2_service #13302

Closed
sorenhansendk opened this issue Dec 20, 2022 · 4 comments
Closed

Support annotations in google_cloud_run_v2_service #13302

sorenhansendk opened this issue Dec 20, 2022 · 4 comments
Assignees

Comments

@sorenhansendk
Copy link
Contributor

sorenhansendk commented Dec 20, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Please add an option to add annotations on services like we have on the V1 ressource: google_cloud_run_service

It's pretty good when you need to add custom annotations OR annotations there not is supported by the provider.

In this example is the CPU boost feature not supported by the current implementation. The new annotations should of course be merged, with the annotations there is added by the implementation here.

New or Affected Resource(s)

  • google_cloud_run_v2_service

Potential Terraform Configuration

resource "google_cloud_run_v2_service" "default" {
  name     = "cloudrun-service"
  location = "us-central1"

  template {
    containers {
      image = "us-docker.pkg.dev/cloudrun/container/hello"
    }
    annotations = {
      "run.googleapis.com/startup-cpu-boost" = "true"
    }
  }
}

References

@JhoLee
Copy link

JhoLee commented Dec 21, 2022

I'm also looking forward it to be impleneted soon!🙃
I had to use VPC Access and Filestore in cloud run v2, but google_cloud_run_service doesn't support VPC Access (which is supporting annotations) so it could not mount filestore in another vpc).

@JhoLee
Copy link

JhoLee commented Dec 21, 2022

I'm also looking forward it to be impleneted soon!🙃 I had to use VPC Access and Filestore in cloud run v2, but google_cloud_run_service doesn't support VPC Access (which is supporting annotations) so it could not mount filestore in another vpc).

Oh, I fixed it by adding template.0.execution_environment = "EXECUTION_ENVIRONMENT_GEN2".

BTW, I'm still looking forward to use annotations :)
image

@hao-nan-li
Copy link
Collaborator

GoogleCloudPlatform/magic-modules#7023

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants