Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for add/remove updates on list fields to MMv1 #17799

Open
rileykarson opened this issue Apr 8, 2024 · 1 comment
Open

Add support for add/remove updates on list fields to MMv1 #17799

rileykarson opened this issue Apr 8, 2024 · 1 comment
Labels
mmv1-generator Provider-wide changes to resource templates or other generator changes size/l technical-debt
Milestone

Comments

@rileykarson
Copy link
Collaborator

What kind of contribution is this issue about?

MMv1-based resource

Details

See #2570 for an example case. Note that even that is a complex case- there's a single method with conditions (only add or only remove, no mixing) rather than distinct methods that we can call.

We currently assume a resource has a standard update or each field a single custom update. With this change we'd support multiple calls depending on the exact change. This may be resolved by a new custom code injection point rather than full templating, given there are a small # of cases.

References

@rileykarson rileykarson added technical-debt mmv1-generator Provider-wide changes to resource templates or other generator changes labels Apr 8, 2024
@rileykarson rileykarson added this to the Goals milestone Apr 29, 2024
@rileykarson
Copy link
Collaborator Author

Note: We can always do custom_update, pre_update, and post_update in the meantime while this is not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mmv1-generator Provider-wide changes to resource templates or other generator changes size/l technical-debt
Projects
None yet
Development

No branches or pull requests

1 participant