Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWP: allow fields certificateUrls, gatewaySecurityPolicy to be updated #17801

Open
liudmila-udot opened this issue Apr 8, 2024 · 0 comments
Open

Comments

@liudmila-udot
Copy link

liudmila-udot commented Apr 8, 2024

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

Now certificate_urls field annotated with ForceNew

"certificate_urls": {
Type: schema.TypeList,
Optional: true,
ForceNew: true,
Description: `A fully-qualified Certificates URL reference. The proxy presents a Certificate (selected based on SNI) when establishing a TLS connection.
This feature only applies to gateways of type 'SECURE_WEB_GATEWAY'.`,
Elem: &schema.Schema{
Type: schema.TypeString,
},
},
. That makes certificate rotations process very disruptive - causing ~1m of gateway unavailability.

PATCH API itself supports updating certificate_urls: https://cloud.google.com/api-gateway/docs/reference/rest/v1/projects.locations.gateways/patch

Same issue was discussed here: #14600

New or Affected Resource(s)

  • google_network_services_gateway

Potential Terraform Configuration

Tests are already written
https://github.com/GoogleCloudPlatform/magic-modules/blob/cb9e3ed179edc64b4b0021e4966680259914a29e/mmv1/third_party/terraform/services/networkservices/resource_network_services_gateway_test.go#L172

We just have to uncomment them and delete immutable in 2 places:

References

#14600

b/337872944

@rileykarson rileykarson added size/s and removed forward/review In review; remove label to forward labels Apr 29, 2024
@rileykarson rileykarson added this to the Goals milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants