Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch MM unit test workflows based on modular-magician downstream SHAs instead of branches #17924

Open
melinath opened this issue Apr 19, 2024 · 0 comments · May be fixed by GoogleCloudPlatform/magic-modules#10671

Comments

@melinath
Copy link
Collaborator

What kind of contribution is this issue about?

Other (specify in details)

Details

We currently dispatch workflows like https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.github/workflows/test-tgc.yml based on a branch, which can lead to issues with TGC specifically where it can end up installing an older version of TPG (and then failing to compile) - for example, https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/8759519595/job/24042712410.

This could also hypothetically lead to race conditions if multiple commits are pushed close to each other, resulting in unit tests running for a newer SHA than intended.

We should pass specific SHAs to GHA workflows - and for TGC we should pass a SHA for TPGB in addition to one for TGC.

Ideally we would pass the downstream SHAs from the cloud build step that commits them to the steps that consume them, but I'm not sure offhand whether cloud build supports that.

References

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants