Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing failures of missing-test-detector #17943

Closed
SarahFrench opened this issue Apr 24, 2024 · 1 comment
Closed

Confusing failures of missing-test-detector #17943

SarahFrench opened this issue Apr 24, 2024 · 1 comment

Comments

@SarahFrench
Copy link
Member

What kind of contribution is this issue about?

Other (specify in details)

Details

Sometimes the missing test detector falsely flags that a given field isn't present in a test. If there's a problem with the tool it should be updated, or if people are misunderstanding the feedback the tool is giving there should be additonal documentation etc. For example if the tool can it only look at generated tests and cannot inspect handwritten tests then the PR reviewer can ignore the feedback confidently if they know this and confirm the PR adds a handwritten test.

References

Example of the tool being confusing: GoogleCloudPlatform/magic-modules#10515 (comment)

@rileykarson
Copy link
Collaborator

Note: There is sometimes misleading feedback. In this case the user used a block for a map & there was an error prompting the failure. There are some cases where the missing test detector does not properly find test cases due to different config formattings.

We could encourage contributors to self-explore failures in docs or make the test format more prescriptive.

Closing this as a general issue; but we should file bugs for specific failures or confusing cases.

@rileykarson rileykarson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants