Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoscaling to DPMS terraform #10522

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brandon-m-hansen
Copy link

@brandon-m-hansen brandon-m-hansen commented Apr 24, 2024

This PR adds the scaling_config field to the google_dataproc_metastore_service beta resource. This PR fixes 17949
The autoscaling_config field enables the user to create a DPMS2 service with autoscaling enabled using Terraform.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dataprocmetastore: added `autoscaling_config` field to `google_dataproc_metastore_service` resource

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/metastore and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Apr 24, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 182 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 182 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_metastore_service (22 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_metastore_service" "primary" {
  scaling_config {
    autoscaling_config {
      autoscaling_enabled = # value needed
      limit_config {
        max_scaling_factor = # value needed
        min_scaling_factor = # value needed
      }
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 14
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • dataprocmetastore

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@github-actions github-actions bot requested a review from NickElliot May 1, 2024 19:15
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 1, 2024
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 1, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 28 insertions(+))
google-beta provider: Diff ( 2 files changed, 181 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_metastore_service (22 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_metastore_service" "primary" {
  scaling_config {
    autoscaling_config {
      autoscaling_enabled = # value needed
      limit_config {
        max_scaling_factor = # value needed
        min_scaling_factor = # value needed
      }
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 14
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • dataprocmetastore

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples need to be added to the block further up in the file, see here bullet #5

@github-actions github-actions bot requested a review from NickElliot May 6, 2024 15:54
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 6, 2024
Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need the examples added up here! Thanks

@github-actions github-actions bot requested a review from NickElliot May 9, 2024 16:51
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 10, 2024
add autoscaling to DPMS terraform provider

Update mmv1/templates/terraform/examples/go/dataproc_metastore_service_autoscaling_max_scaling_factor.tf.tmpl

Co-authored-by: Nick Elliot <nickelliot@google.com>

Update mmv1/templates/terraform/examples/go/dataproc_metastore_service_autoscaling_min_and_max_scaling_factor.tf.tmpl

Co-authored-by: Nick Elliot <nickelliot@google.com>

Update mmv1/templates/terraform/examples/go/dataproc_metastore_service_autoscaling_no_limit_config.tf.tmpl

Co-authored-by: Nick Elliot <nickelliot@google.com>

Update mmv1/templates/terraform/examples/go/dataproc_metastore_service_autoscaling_min_scaling_factor.tf.tmpl

Co-authored-by: Nick Elliot <nickelliot@google.com>

Fixes GITHUB_ISSUE_LINK
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 13, 2024
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/metastore
Projects
None yet
3 participants