New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autoscaling to DPMS terraform #10522
base: main
Are you sure you want to change the base?
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataproc_metastore_service" "primary" {
scaling_config {
autoscaling_config {
autoscaling_enabled = # value needed
limit_config {
max_scaling_factor = # value needed
min_scaling_factor = # value needed
}
}
}
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataproc_metastore_service" "primary" {
scaling_config {
autoscaling_config {
autoscaling_enabled = # value needed
limit_config {
max_scaling_factor = # value needed
min_scaling_factor = # value needed
}
}
}
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...ates/terraform/examples/go/dataproc_metastore_service_autoscaling_min_scaling_factor.tf.tmpl
Outdated
Show resolved
Hide resolved
...mplates/terraform/examples/go/dataproc_metastore_service_autoscaling_no_limit_config.tf.tmpl
Outdated
Show resolved
Hide resolved
...raform/examples/go/dataproc_metastore_service_autoscaling_min_and_max_scaling_factor.tf.tmpl
Outdated
Show resolved
Hide resolved
...ates/terraform/examples/go/dataproc_metastore_service_autoscaling_max_scaling_factor.tf.tmpl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need the examples added up here! Thanks
add autoscaling to DPMS terraform provider Update mmv1/templates/terraform/examples/go/dataproc_metastore_service_autoscaling_max_scaling_factor.tf.tmpl Co-authored-by: Nick Elliot <nickelliot@google.com> Update mmv1/templates/terraform/examples/go/dataproc_metastore_service_autoscaling_min_and_max_scaling_factor.tf.tmpl Co-authored-by: Nick Elliot <nickelliot@google.com> Update mmv1/templates/terraform/examples/go/dataproc_metastore_service_autoscaling_no_limit_config.tf.tmpl Co-authored-by: Nick Elliot <nickelliot@google.com> Update mmv1/templates/terraform/examples/go/dataproc_metastore_service_autoscaling_min_scaling_factor.tf.tmpl Co-authored-by: Nick Elliot <nickelliot@google.com> Fixes GITHUB_ISSUE_LINK
This PR adds the
scaling_config
field to thegoogle_dataproc_metastore_service
beta resource. This PR fixes 17949The
autoscaling_config
field enables the user to create a DPMS2 service with autoscaling enabled using Terraform.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)