Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server ca attribute to google_redis_cluster #17958

Open
lennykean opened this issue Apr 25, 2024 · 2 comments
Open

Add server ca attribute to google_redis_cluster #17958

lennykean opened this issue Apr 25, 2024 · 2 comments

Comments

@lennykean
Copy link

lennykean commented Apr 25, 2024

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

Redis cluster resources should provide a computed attribute for server_ca_certs similar to redis instance resources, which is available in the Memorystore REST API

New or Affected Resource(s)

  • google_redis_cluster

Potential Terraform Configuration

References

https://cloud.google.com/memorystore/docs/cluster/reference/rest/v1/projects.locations.clusters/getCertificateAuthority

b/337873086

@github-actions github-actions bot added forward/review In review; remove label to forward service/redis-cluster labels Apr 25, 2024
@rileykarson
Copy link
Collaborator

Note: We added this to the google_redis_instance resource directly, but got feedback that some users would have preferred it be added separately, to avoid having secrets in state in the general case. We could consider using that approach here, using a datasource instead.

@rileykarson rileykarson added size/s and removed forward/review In review; remove label to forward labels Apr 29, 2024
@rileykarson rileykarson added this to the Goals milestone Apr 29, 2024
@lennykean
Copy link
Author

I'm not sure why the ca certs would be secrets. As far as I know, they don't expose the private keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants