Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tag Hold for Access Control #18153

Open
roxannelandry opened this issue May 15, 2024 · 0 comments
Open

Add Tag Hold for Access Control #18153

roxannelandry opened this issue May 15, 2024 · 0 comments

Comments

@roxannelandry
Copy link

roxannelandry commented May 15, 2024

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

Currently, we can create tags and bind them to resources, which is great. But here's the thing: we're missing a crucial piece. We can't put a hold on that binding, which means there's no way to prevent the deletion of a tag, even if it's associated with critical resources.

Here's what I'm thinking: it would be super helpful to have the ability to add holds to resource tags. This would allow us to designate certain tags as critical, and prevent their deletion in critical environments. Essentially, it would give us an added layer of control over our resources, ensuring that important tags are maintained, especially in high-stakes scenarios.

Implementing this feature would provide users with a cleaner and more secure way to manage tags and resources within GCP projects.

Thanks for considering this suggestion!

https://cloud.google.com/resource-manager/docs/tags/tags-creating-and-managing#protecting_tags

New or Affected Resource(s)

google_tags_location_tag_hold

Potential Terraform Configuration

resource "google_tags_location_tag_hold" "public_assets_bucket_tag_hold" {
  holder    = "//storage.googleapis.com/projects/_/buckets/${google_storage_bucket.public_assets.name}"
  location  = var.gcp_region
  tag_value = var.dm_environments_tag_value_id
}

References

No response

b/341735543

@github-actions github-actions bot added forward/review In review; remove label to forward service/cloudresourcemanager-tags labels May 15, 2024
@melinath melinath added new-resource size/m and removed forward/review In review; remove label to forward labels May 20, 2024
@melinath melinath added this to the Goals milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants