Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address resource_dataflow_job drain on batch type jobs #5796

Closed
c2thorn opened this issue Feb 28, 2020 · 2 comments
Closed

Address resource_dataflow_job drain on batch type jobs #5796

c2thorn opened this issue Feb 28, 2020 · 2 comments
Labels
breaking-change forward/linked persistent-bug Hard to diagnose or long lived bugs for which resolutions are more like feature work than bug work service/dataflow size/s
Milestone
6.0.0

Comments

@c2thorn
Copy link
Collaborator

c2thorn commented Feb 28, 2020 •
edited by modular-magician

Affected Resource(s)

  • google_dataflow_job

TestAccDataflowJob_withRegion attempts to drain a batch dataflow job. We either need to make this not possible, or explicitly state that setting on_delete=drain for batch type jobs will wait for the job to finish on destroy.

b/340204067
@danawillow danawillow added this to the Backlog milestone Mar 2, 2020
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Mar 15, 2022
@modular-magician @melinath
Add billingType attribute to Apigee Organization resource (hashicorp#…
b121309 
…5796)

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Mar 15, 2022
@modular-magician @melinath
Add billingType attribute to Apigee Organization resource (#5796) (#1…
f37276b 
…1285)

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
@rileykarson rileykarson added breaking-change persistent-bug Hard to diagnose or long lived bugs for which resolutions are more like feature work than bug work and removed enhancement labels Jun 20, 2023
@rileykarson
Copy link
Collaborator

Given "We either need to make this not possible" marking as a breaking change. Documentation would be possible outside of one of those windows, though.

@github-actions github-actions bot added forward/review In review; remove label to forward service/dataflow labels Oct 5, 2023
@c2thorn c2thorn removed the forward/review In review; remove label to forward label May 13, 2024
@c2thorn
Copy link
Collaborator Author

c2thorn commented May 14, 2024

closed by service team

@c2thorn c2thorn closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change forward/linked persistent-bug Hard to diagnose or long lived bugs for which resolutions are more like feature work than bug work service/dataflow size/s
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
4 participants
@danawillow @rileykarson @c2thorn @modular-magician