Change the default for google_sql_database.deletion_policy to DELETE #13226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13206
As mentioned in #13206 (comment), this change is technically a breaking change- but it's also fixing a regression in the resource, so it's being made in a minor version anyways. It will result in a diff, which I've called out in the changelog entry (intentionally included twice, as a bugfix and a note)
This wasn't caught by our tests because the testcheckdestroy runs after
terraform destroy
, and deleting the instance deleted the database.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6936