Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigtable: table deletion protection support #13232

Conversation

modular-magician
Copy link
Collaborator

  • Add deletion_protection field to resourceBigtableTable
  • deletion_protection should be string type as we need to determine if the field is given or not
  • Deletion protection support while creating a table, reading a table and updating a table using terraform
  • Adding supporting unit tests for different scenarios while creating a table with enabled deletion protection or disabled deletion protection.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigtable: supported table deletion protection in terraform

Derived from GoogleCloudPlatform/magic-modules#6722

Co-authored-by: Cameron Thornton <camthornton@google.com>
Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: Luca Prete <lucaprete@google.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Aleksandr Averbukh <averbukh@google.com>
Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com>
Co-authored-by: Jay Sanghani <111726632+sanghaniJ@users.noreply.github.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: AlfatahB <111489009+AlfatahB@users.noreply.github.com>
Co-authored-by: Kevin Si <kevinsi4508@gmail.com>
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
Co-authored-by: Mikołaj Siedlarek <mikolaj@siedlarek.net>
Co-authored-by: Avi Dave <avi.dave@mail.utoronto.ca>
Co-authored-by: Grigory Solomin <5736535+gsolomin@users.noreply.github.com>
Co-authored-by: Avi Dave <avidave97@gmail.com>
Co-authored-by: Ryan Oaks <ryanoaks@google.com>
Co-authored-by: Haruaki OTAKE <aaharu@hotmail.com>
Co-authored-by: x <xuruicheng96@gmail.com>
Co-authored-by: sakuya9t <4102161+sakuya9t@users.noreply.github.com>
Co-authored-by: Luca Prete <preteluca@gmail.com>
Co-authored-by: aniketkumarj <112697326+aniketkumarj@users.noreply.github.com>
Co-authored-by: Terrence Ryan <tpryan@google.com>
Co-authored-by: Sam Levenick <slevenick@google.com>
Co-authored-by: Shotaro Kohama <khmshtr28@gmail.com>
Co-authored-by: Francis (Feng) Liu <Francis.Liu2012@gmail.com>
Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com>
Co-authored-by: Søren Hansen <hello@severinus.io>
Co-authored-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com>
Co-authored-by: t-indumathy <30333884+t-indumathy@users.noreply.github.com>
Co-authored-by: AarshDhokai <111489014+AarshDhokai@users.noreply.github.com>
Co-authored-by: Joost Buskermolen <joostbuskermolen@hotmail.com>
Co-authored-by: Benjamin Berriot <40873921+IIBenII@users.noreply.github.com>
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Carl Yeksigian <carl@yeksigian.com>
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: iperetz-goo <108678927+iperetz-goo@users.noreply.github.com>
Co-authored-by: Riley Karson <rileykarson@google.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
Co-authored-by: Daniel Vega-Myhre <105610547+danielvegamyhre@users.noreply.github.com>
Co-authored-by: Neha Vellanki <35039892+neha-vellanki12@users.noreply.github.com>
Co-authored-by: gfxcc <yongcy@google.com>
Co-authored-by: Lingkai Shen <slk49@live.cn>
Co-authored-by: Stenal P Jolly <stenalpjolly@gmail.com>
Co-authored-by: Mohamed Fouad <110571142+mraouffouad@users.noreply.github.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 1120b9f into hashicorp:main Dec 13, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant