Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_container_cluster: add support for new GKE Gateway API controller #13233

Conversation

modular-magician
Copy link
Collaborator

Fixed #13117

If you want to use the new Gateway API Controller inside your GKE clusters you need to be able to define a channel to be used. By default no channel is selected, therefore the GKE Gateway Controller does not install the necessary CRDs and the GatewayClasses.

Gateway API Documentation: https://cloud.google.com/kubernetes-engine/docs/concepts/gateway-api
SDK Documentation: https://cloud.google.com/sdk/gcloud/reference/container/clusters/create#--gateway-api
GOlang Reference: https://pkg.go.dev/google.golang.org/api/container/v1#GatewayAPIConfig

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it.
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: added `gateway_api_config` block to `google_container_cluster` resource for supporting the gke gateway api controller

Derived from GoogleCloudPlatform/magic-modules#6875

…ler (hashicorp#6875)

* add support for gateway api flag

* fix test by adding proper release channel; add missing functions

* add update cluster handling for gateway api config; extend test cases for gateway api config

* remove problematic / unrecognized channels from gateway api; these channels are mentioned in the actual code base but are not recognized by the gcloud api

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 7c54260 into hashicorp:main Dec 13, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_container_cluster add support for selecting gateway api channel when creating or updating a GKE cluster
1 participant