Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument for the Helm reset-then-reuse-values flag #1321

Open
SCHrodrigo opened this issue Jan 31, 2024 · 1 comment
Open

Argument for the Helm reset-then-reuse-values flag #1321

SCHrodrigo opened this issue Jan 31, 2024 · 1 comment

Comments

@SCHrodrigo
Copy link

SCHrodrigo commented Jan 31, 2024

Description

A feature that the team I work with has been happy with is the flag reset-then-reuse-values. It makes the upgrades to charts with new default values work flawlessly, only using reuse ignores those values, so the upgrade fails because they are needed, and reset would lose the original data.

A better discussion about this is on a Helm repo PR.

Looking at the current docs of the module, reset and reuse are separate arguments, reset taking preference.

I think having one more arg for reset_then_reuse_values would be great. It would be prioritized over both flags alone.

Edit: I forgot to clarify that this would be 100% dependent on upgrading Helm to 3.14.0. Dependabot already created a PR for this.

Potential Terraform Configuration

reset_then_reuse_values = true # false

References

Pull request that upgrades Helm to 3.14.0
Original issue in the Helm repo about the flag
Current docs on the available flags
Helm docs about the flag

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@andyli
Copy link

andyli commented Apr 13, 2024

The aws-ebs-csi-driver helm chart removed its support of --reuse-values in favor of --reset-then-reuse-values since v2.29.0.

Those who use reuse_values = true of the chart will need to do helm chart upgrade outside of terraform-provider-helm for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants