-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PersistentVolumeLastPhaseTransitionTime
feature gate field lastPhaseTransitionTime
in PersistentVolumeStatus
#2399
Comments
Hi, I am interested to work on this issue! |
@theloneexplorerquest you're more then welcome to open a PR! We appreciate contributions from the community to improve the provider. We can assist you on PR if needed |
Hi @BBBmau thanks for message, From what I understand, for the actual code, I need to have an if-else statement at https://github.com/hashicorp/terraform-provider-kubernetes/blob/main/kubernetes/resource_kubernetes_persistent_volume_v1.go#L243 My question is: do we want to output this attribute in terraform at all? Because I did not see I will make the code change and do some test too. |
@theloneexplorerquest it makes sense to include both message and reason as part of the log. You can also add those along with lastPhaseTransitionTime. and yes it looks like depending on the phase you'll want the log to output a different message. a failed status would include |
Hi @BBBmau, I have created the PR, can you take a look? This is the error message I got for
Suspect I got some issues with ca certificate but wasn't able to identify it yet. if Acceptance test is required I will figure it out in the next few weeks |
No need for a test since the |
Description
PersistentVolumeLastPhaseTransitionTime was recently graduated to beta and includes a new field as part of
PersistentVolumeStatus
Potential Terraform Configuration
References
Community Note
The text was updated successfully, but these errors were encountered: