Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image_pull_secrets are not removed from deployment #2445

Open
viceice opened this issue Mar 18, 2024 · 1 comment
Open

image_pull_secrets are not removed from deployment #2445

viceice opened this issue Mar 18, 2024 · 1 comment
Assignees
Labels

Comments

@viceice
Copy link

viceice commented Mar 18, 2024

Terraform Version, Provider Version and Kubernetes Version

Terraform version: 1.7.5
Kubernetes provider version: 2.27.0
Kubernetes version: 1.28.7

Affected Resource(s)

  • kubernetes_deployment

Terraform Configuration Files

resource "kubernetes_deployment" "whoami" {
  metadata {
    name      = "whoami"
    labels = {
      app = "whoami"
    }
  }
  spec {
    replicas = 1

    selector {
      match_labels = {
        app = "whoami"
      }
    }
    template {
      metadata {
        labels = {
          app = "whoami"
        }
      }
      spec {
        container {
          image = "traefik/whoami"
          name  = "whoami"
          
        }
        
        # remove after initial deploy
        image_pull_secrets {
          name = "docker-cfg"
        }
      }
    }
  }
}

Debug Output

Panic Output

Steps to Reproduce

  1. terraform apply
  2. remove pull secret
  3. terraform apply
  4. see that pull screcret isn't removed

Expected Behavior

What should have happened?

pull secret should be removed from deployment

Actual Behavior

What actually happened?

pull secret is still there

Important Factoids

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@viceice viceice added the bug label Mar 18, 2024
@viceice
Copy link
Author

viceice commented Mar 18, 2024

I remove the pull secrets a long time ago with older versions.
I don't on the versions used, so now you see the current versions in use.

@sheneska sheneska self-assigned this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants