Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support x509/DER/SHA256 public key fingerprint #202

Open
1 task done
alanraison opened this issue May 4, 2022 · 0 comments · May be fixed by #203
Open
1 task done

Support x509/DER/SHA256 public key fingerprint #202

alanraison opened this issue May 4, 2022 · 0 comments · May be fixed by #203

Comments

@alanraison
Copy link

Terraform CLI and Provider Versions

Terraform v1.1.9
on darwin_arm64

Use Cases or Problem Statement

When trying to configure an OIDC provider, I needed a particular checksum to be supported; namely the SHA256 hash of the DER-formatted public key.

Proposal

I propose that a new attribute, public_key_fingerprint_x509_sha256 is added to the tls_private_key resource and the tls_public_key data source.

The hash algorithm seems to use standard encryption methods and Go libraries and hence seems to align with the design guidelines. However, it may cause property bloat to the tls_private_key resource and tls_public_key data source.

How much impact is this issue causing?

Medium

Additional Information

I have proposed the change in this provider, rather than writing a separate one, as it already has access to the key material (and indeed uses the x509 package already).

Code of Conduct

  • I agree to follow this project's Code of Conduct
@alanraison alanraison linked a pull request May 4, 2022 that will close this issue
@detro detro added the tf-devex-triage Terraform DevEx project tracking label May 16, 2022
@bflad bflad unassigned detro Aug 1, 2022
@bookshelfdave bookshelfdave removed the tf-devex-triage Terraform DevEx project tracking label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants