SCSI IDs changing on machines built with 2.60+ was claimed to be fixed but its not

[baltox61]

Community Guidelines

• I have read and agree to the HashiCorp Community Guidelines .
• Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
• Do not leave "+1" or other comments that do not add relevant information or questions.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Terraform

1.7.5

Terraform Provider

2.7.0

VMware vSphere

8.0.2.00200

Description

This change
https://github.com/hashicorp/terraform-provider-vsphere/pull/2115/files#diff-e8de2d20cbf49f2db545eafc50b5230673e69274016a107bc7c75f6adcb1d635

doesnt resolve the issue because it is looking at the physical_function variable

terraform-provider-vsphere/vsphere/internal/virtualdevice/virtual_machine_network_interface_subresource.go

Lines 103 to 107 in baef89b

	"physical_function": {
	Type: schema.TypeString,
	Optional: true,
	Description: "The ID of the Physical SR-IOV NIC to attach to, e.g. '0000:d8:00.0'",
	},

This ticket was closed and should not have:
#2089

which is always going to change since we are creating a new nic everytime.
Since we are creating an additional disk, that disk gets created first, takes the slot needed for the nic https://git.enova.com/tf-modules/tf_enova_vsphere_vm/blob/d235bc0f5cfb33651d8c3087f515f542182b6155/locals.tf#L102

Affected Resources or Data Sources

resource/vsphere_virtual_machine

Terraform Configuration

Error: timeout waiting for an available IP address

Debug Output

Just reopening ticket thats not fixed

Panic Output

No response

Expected Behavior

To be able to apply with w scsi disks

Actual Behavior

Error: timeout waiting for an available IP address

Steps to Reproduce

Have 2 scsi controllers on vm creation

Environment Details

No response

Screenshots

No response

References

No response

[github-actions]

Hello, baltox61! 🖐

Thank you for submitting an issue for this provider. The issue will now enter into the issue lifecycle.

If you want to contribute to this project, please review the contributing guidelines and information on submitting pull requests.

[gavinwill]

Hi - I created the original issue and i can confirm our ordering of nics is still inconsistent for new machines created with 2.7.0+

I can obtain more debug information if needed. So yes this still seems problematic.