From 777d50564526e4bbd2791a62f8fc29b28640e527 Mon Sep 17 00:00:00 2001 From: Charlie Getzen Date: Fri, 29 May 2020 11:34:34 -0700 Subject: [PATCH] Add tests for code coverage (configs) --- .../variable-validation-error-msg-badref.tf | 12 ++++++++++++ terraform/eval_variable.go | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 configs/testdata/invalid-files/variable-validation-error-msg-badref.tf diff --git a/configs/testdata/invalid-files/variable-validation-error-msg-badref.tf b/configs/testdata/invalid-files/variable-validation-error-msg-badref.tf new file mode 100644 index 000000000000..8d6513f044ec --- /dev/null +++ b/configs/testdata/invalid-files/variable-validation-error-msg-badref.tf @@ -0,0 +1,12 @@ + +locals { + foo = 1 +} + +variable "validation" { + default = 1 + validation { + condition = var.validation == 1 + error_message = "Must be ${local.foo}." # ERROR: Invalid reference in variable validation + } +} diff --git a/terraform/eval_variable.go b/terraform/eval_variable.go index f34db80c082c..a5e1d682a4db 100644 --- a/terraform/eval_variable.go +++ b/terraform/eval_variable.go @@ -211,7 +211,7 @@ func (n *evalVariableValidations) Eval(ctx EvalContext) (interface{}, error) { diags = diags.Append(&hcl.Diagnostic{ Severity: hcl.DiagError, Summary: errInvalidCondition, - Detail: "Validation condition expression must return either true or false, not null.", + Detail: "Validation error message expression must return a string, not null.", Subject: validation.ErrorMessage.Range().Ptr(), Expression: validation.ErrorMessage, EvalContext: hclCtx,