Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitive inputs are visible in terminal #29609

Closed
kamil-wojcik opened this issue Sep 19, 2021 · 7 comments · May be fixed by #29639
Closed

Sensitive inputs are visible in terminal #29609

kamil-wojcik opened this issue Sep 19, 2021 · 7 comments · May be fixed by #29639
Labels
enhancement v1.0 Issues (primarily bugs) reported against v1.0 releases

Comments

@kamil-wojcik
Copy link

Terraform Version

terraform version
Terraform v1.0.7
on linux_amd64

Terraform Configuration Files

variable "secret" {
    sensitive = true
}

variable "plain" {
    sensitive = false
}

Debug Output

terraform plan
var.plain
  Enter a value: plain-value

var.secret
  Enter a value: secret-value


No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are
needed.

Crash Output

Expected Behavior

Input for sensitive variables should be masked

Actual Behavior

When value for sensitive variable is given it is visible on console.

Steps to Reproduce

Additional Context

References

I would be happy to prepare fix for it.

@kamil-wojcik kamil-wojcik added bug new new issue not yet triaged labels Sep 19, 2021
@alisdair alisdair added enhancement v1.0 Issues (primarily bugs) reported against v1.0 releases and removed bug new new issue not yet triaged labels Sep 21, 2021
@patchon
Copy link

patchon commented Mar 1, 2022

Took me a couple of hours to get here.
From a personal perspective I think this makes perfect sense.
If I mark a variable sensitive = true, I would expect terraform to mask the input when asking.

@TechDufus
Copy link

+10000 for this feature.
Would love to see sensitive variables masked when typed in at the console.

@jhvhs
Copy link

jhvhs commented Oct 5, 2022

Seems like a duplicate of #28122

@crw
Copy link
Collaborator

crw commented Oct 5, 2022

Agreed, although I am going to retain this issue as I think the description is a bit easier to understand.

@mbenson
Copy link

mbenson commented Dec 12, 2022

How is this still open?

@crw
Copy link
Collaborator

crw commented Dec 16, 2022

Closed by #29520

@crw crw closed this as completed Dec 16, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement v1.0 Issues (primarily bugs) reported against v1.0 releases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants