Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: go get github.com/hashicorp/hcl/v2@v2.12.0 #30920

Merged
merged 1 commit into from Apr 25, 2022
Merged

Conversation

apparentlymart
Copy link
Member

@apparentlymart apparentlymart commented Apr 22, 2022

This tagged release is a superset of the specific commit we had previously selected, adding in just an improved error message for inconsistent result types in a conditional expression.

The error message for #30562 would become the following after merging this:

╷
│ Error: Inconsistent conditional result types
│ 
│   on fun-with-tuples.tf line 20, in output "test":
│   20:   value = true ? { foo = { bar = 42 } } : { bar = 44 }
│ 
│ The true and false result expressions must have consistent types.
│ The 'true' value includes object attribute "foo", which is absent
│ in the 'false' value.
╵

This fixes #30562 and fixes #29226. (by improving the error message to be more specific, not by changing what is valid.)

This tagged release is a superset of the specific commit we had previously
selected, adding in just an improved error message for inconsistent result
types in a conditional expression.
@apparentlymart apparentlymart merged commit 09ab872 into main Apr 25, 2022
@apparentlymart apparentlymart deleted the f-hcl-v2.12.0 branch April 25, 2022 16:46
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants