Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update golang.org/x/crypto again #31092

Merged
merged 1 commit into from May 20, 2022
Merged

update golang.org/x/crypto again #31092

merged 1 commit into from May 20, 2022

Conversation

nilsding
Copy link
Contributor

The version that was in use previously broke my runs using ssh-agent with a signed ed25519 key with a nice ssh: handshake failed: agent unsupported algorithm "ssh-ed25519" error. I took a further look into this, and saw that the upstream change that broke it for me was fixed in golang/crypto@46612604a -- therefore I just updated this dependency again to the (as the time of writing) latest version.

If possible this change needs a backport to terraform 1.2, as this is the version I tried to use ...

@hashicorp-cla
Copy link

hashicorp-cla commented May 20, 2022

CLA assistant check
All committers have signed the CLA.

The version that was in use previously broke my runs with a nice `ssh:
handshake failed: agent unsupported algorithm "ssh-ed25519"` error.  I
took a further look into this, and saw that the change that broke ssh
for me was fixed in golang/crypto@46612604a.
Yay!
@jbardin jbardin added the 1.2-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label May 20, 2022
@jbardin jbardin self-assigned this May 20, 2022
@jbardin
Copy link
Member

jbardin commented May 20, 2022

Thanks for digging into this @nilsding!

@jbardin jbardin merged commit 94f68a2 into hashicorp:main May 20, 2022
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.2-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants