Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configs: Fix check block configuration diagnostics #31290

Merged
merged 1 commit into from Jun 22, 2022

Conversation

alisdair
Copy link
Member

When validating self-references for resource and data source preconditions and postconditions, we previously did not nil-check the block's condition field, which caused a panic when the block had no condition.

While fixing this I noticed that we were not validating that there are no self-references in the error message, so fixed that. As a result you'll probably want to ignore whitespace when reviewing the diff.

Fixes #31288

When validating self-references for resource and data source
preconditions and postconditions, we previously did not nil-check the
block's condition field, which caused a panic when the block had no
condition.

While fixing this I noticed that we were not validating that there are
no self-references in the error message, so fixed that.
@alisdair alisdair added the 1.2-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Jun 21, 2022
@alisdair alisdair requested a review from a team June 21, 2022 16:39
@alisdair alisdair self-assigned this Jun 21, 2022
@alisdair alisdair merged commit 5df6bac into main Jun 22, 2022
@alisdair alisdair deleted the alisdair/check-block-missing-condition branch June 22, 2022 15:51
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.2-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing condition in check block causes crash
2 participants