Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providercache: include host in provider installation error #31524

Merged
merged 1 commit into from Jul 29, 2022

Conversation

radeksimko
Copy link
Member

This is motivated by issues of the nature described in #31516 which we also noticed as part of our regular CI runs recently which runs terraform init for all ~250 official+verified providers.

https://github.com/hashicorp/terraform-ls/runs/7467545895?check_suite_focus=true#step:6:43

It aims to turn the following error:

Error while installing bluecatlabs/bluecat v1.0.0: local error: tls: bad record MAC

into

Error while installing bluecatlabs/bluecat v1.0.0: github.com: local error: tls: bad record MAC

The aim here is to communicate the fact that (often) such networking issues are between the user and GitHub, rather than the Terraform Registry - and if it is in fact the Registry then should allow us (and the user) to tell the errors apart.

This is similar to #30810

@radeksimko radeksimko merged commit c1fc7fd into main Jul 29, 2022
@radeksimko radeksimko deleted the f-include-host-in-prov-install-err branch July 29, 2022 09:50
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants